Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dual alg: add ML-DSA test, and misc cleanup. #8425

Merged
merged 4 commits into from
Feb 10, 2025
Merged

dual alg: add ML-DSA test, and misc cleanup. #8425

merged 4 commits into from
Feb 10, 2025

Conversation

philljj
Copy link
Contributor

@philljj philljj commented Feb 6, 2025 •
edited
Loading

Description

Add a dual-alg ML-DSA + ECDSA test, and some miscellaneous cleanup:

  • Add test_dual_alg_ecdsa_mldsa() to tests/api.c (Based on ecdsa + mldsa demo here: https://github.com/wolfSSL/wolfssl-examples/tree/master/X9.146).
  • Add missing comments to ASN functions, and trim line lengths.
  • Remove unused WOLFSSL_LOCAL function wc_ConfirmAltSignature().
  • Add missing wc_MlDsaKey_*KeyToDer() define to wolfssl/wolfcrypt/dilithium.h

Testing

./configure --enable-experimental --enable-dual-alg-certs --enable-dilithium --enable-debug && make
./tests/unit.test --list | grep dual_alg
338: test_dual_alg_support
339: test_dual_alg_ecdsa_mldsa
./tests/unit.test -339

@philljj philljj self-assigned this Feb 6, 2025
@philljj
Copy link
Contributor Author

philljj commented Feb 7, 2025

retest this please

@philljj philljj requested a review from anhu February 7, 2025 17:14
@philljj philljj assigned anhu and wolfSSL-Bot and unassigned philljj Feb 7, 2025
anhu
anhu previously approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@anhu anhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anhu anhu requested a review from wolfSSL-Bot February 7, 2025 20:09
@anhu anhu removed their assignment Feb 7, 2025
SparkiDev
SparkiDev previously requested changes Feb 10, 2025
View reviewed changes
src/x509.c Outdated Show resolved Hide resolved
wolfcrypt/src/asn.c Show resolved Hide resolved
wolfcrypt/src/asn.c Show resolved Hide resolved
wolfcrypt/src/asn.c Show resolved Hide resolved
@philljj
Copy link
Contributor Author

philljj commented Feb 10, 2025

retest this please

@dgarske dgarske merged commit be5f203 into wolfSSL:master Feb 10, 2025
173 checks passed
@philljj philljj mentioned this pull request Feb 11, 2025
Merged
@philljj philljj deleted the ecdsa_mldsa_test_api branch February 11, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgarske dgarske dgarske approved these changes

@anhu anhu anhu left review comments

@SparkiDev SparkiDev SparkiDev left review comments

@wolfSSL-Bot wolfSSL-Bot Awaiting requested review from wolfSSL-Bot

Assignees

@wolfSSL-Bot wolfSSL-Bot

@philljj philljj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@philljj @anhu @dgarske @SparkiDev @wolfSSL-Bot