update grafana-mimir to build additional subpkgs like mimirtool, etc... #39230
Comments
|
thank you for the issue, adding subpackages is fine here. This looks independent of mimir image and more like client side tooling. I can get to it during weekends but please go ahead if you want to create a patch for this. It should be straight forward to build using go/build pipeline. subpackage tests for those binaries will need some work. |
15 tasks
kranurag7
pushed a commit
that referenced
this issue
Jan 12, 2025
<!--- update grafana-mimir to build additional subpkgs like metaconvert, mimirtool, query-tee <!-- Issue [#39230](#39230) --> Fixes: Related: [#39230](#39230) ### Pre-review Checklist <!-- This checklist is mostly useful as a reminder of small things that can easily be forgotten – it is meant as a helpful tool rather than hoops to jump through. At the moment of this PR you have the most information on what all the change will affect, so please take the time to jot it down. Put an `x` in all the items that apply, make notes next to any that haven't been addressed, and remove any items that are not relevant to this PR. --> #### For new package PRs only <!-- remove if unrelated --> - [ ] This PR is marked as fixing a pre-existing package request bug - [ ] Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency - [x] REQUIRED - The package is available under an OSI-approved or FSF-approved license - [x] REQUIRED - The version of the package is still receiving security updates - [ ] This PR links to the upstream project's support policy (e.g. `endoflife.date`) #### For new version streams <!-- remove if unrelated --> - [ ] The upstream project actually supports multiple concurrent versions. - [ ] Any subpackages include the version string in their package name (e.g. `name: ${{package.name}}-compat`) - [ ] The package (and subpackages) `provides:` logical unversioned forms of the package (e.g. `nodejs`, `nodejs-lts`) - [ ] If non-streamed package names no longer built, open PR to withdraw them (see [WITHDRAWING PACKAGES](https://github.com/wolfi-dev/os/blob/main/WITHDRAWING_PACKAGES.md)) #### For package updates (renames) in the base images <!-- remove if unrelated --> When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk) - [ ] REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build - [ ] REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages - [ ] Upon launch, does `apk upgrade --latest` successfully upgrades packages or performs no actions #### For security-related PRs <!-- remove if unrelated --> - [ ] The security fix is recorded in the [advisories](https://github.com/wolfi-dev/advisories) repo #### For version bump PRs <!-- remove if unrelated --> - [ ] The `epoch` field is reset to 0 #### For PRs that add patches <!-- remove if unrelated --> - [ ] Patch source is documented
|
@tuananh PR has been merged. great!!! |
|
the packages are up now. $ wolfictl apk ls https://packages.wolfi.dev/os/x86_64/APKINDEX.tar.gz --latest | rg grafana-
mimir
grafana-mimir-metaconvert-2.15.0-r1.apk
grafana-mimir-mimirtool-2.15.0-r1.apk
grafana-mimir-query-tee-2.15.0-r1.apk
grafana-mimir-2.15.0-r1.apkWith that we can close this issue as completed. Please feel free to open if there's more to it. |
|
Awesome. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
there are a few cli in grafana/mimir that we do not build like
mimirtool,query-tee,metaconvert. we should updategrafana-mimirpackage to build that and emit additional subpkgs.https://github.com/grafana/mimir/tree/main/cmd
The text was updated successfully, but these errors were encountered: