-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airflow/2.10.0 package update #26452
Conversation
octo-sts
bot
commented
Aug 16, 2024
Signed-off-by: wolfi-bot <[email protected]>
Open AI suggestions to solve the build error:
fatal: detected dubious ownership in repository at '/github/home' git config --global --add safe.directory /github/home
|
Open AI suggestions to solve the build error:
|
Open AI suggestions to solve the build error:
|
Open AI suggestions to solve the build error:
|
Signed-off-by: Mark McCormick <[email protected]>
Open AI suggestions to solve the build error:
|
Signed-off-by: Dentrax <[email protected]>
Open AI suggestions to solve the build error:
|
Given: I don't understand how upstream managed to release this. |
bumping werkzeug to 2.3.8 is not possible since it requires connexion to be >= v3. Signed-off-by: Dentrax <[email protected]>
Open AI suggestions to solve the build error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regresses previous fixed CVE
🔎 Scanning "/tmp/artifacts-1/packages/x86_64/airflow-2.10.0-r0.apk"
├── 📄 /opt/airflow/venv/lib/python3.12/site-packages/Werkzeug-2.2.3.dist-info/METADATA, /opt/airflow/venv/lib/python3.12/site-packages/Werkzeug-2.2.3.dist-info/RECORD, /opt/airflow/venv/lib/python3.12/site-packages/Werkzeug-2.2.3.dist-info/top_level.txt
│ 📦 werkzeug 2.2.3 (python)
│ Medium CVE-20[23](https://github.com/wolfi-dev/os/actions/runs/10708180396/job/29690270408?pr=26452#step:9:24)-46136 GHSA-hrfv-mqp8-q5rw fixed in 2.3.8
│
└── 📄 /opt/airflow/venv/lib/python3.12/site-packages/pip/_vendor/vendor.txt
📦 urllib3 1.26.18 (python)
Medium CVE-20[24](https://github.com/wolfi-dev/os/actions/runs/10708180396/job/29690270408?pr=26452#step:9:25)-37891 GHSA-34jh-p97f-mpxf fixed in 1.26.19
Can we instead remove connections functionality? and/or remove werkzeug functionality?
Or do we need provide a public backport of the 2.3.8 fix into 2.2.x series of werkzeug?
Currently we ship airflow 2.9.3 with werkzeug 2.3.8 - is it thus broken / dead-on-arrival? As the above upgrade, claims that airflow is not compatible with werkzeug 2.3.x series, and thus previous mediation, actually just broke the package? |
I've checked for it but it seems it used in lots of parts, i don't think it's possible to drop this dep.
It seems werkzeug also required dep, since it used to create password hashes and handle some HTTP exceptions. README also mentions "werkzeug tightly coupled with Flask libraries"
It'd be great, they don't support older versions. The related CVE fix commit does seem: pallets/werkzeug@f230020 |
Thanks @Dentrax, @xnox, @jamie-albert. Seems like we shouldn't have bumped werkzeug originally as it does like its not compatible, and the above links reaffirm this. Lets leave it at the supported version, and update our advisory to pending-upstream-fix, and we'll keep track for any changes upstream |
We have a path forward, re: comments. Also approaching SLA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, see comments