Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local build bugs - ncurses and libuv #9086

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Local build bugs - ncurses and libuv #9086

merged 3 commits into from
Dec 4, 2023

Conversation

max-allan
Copy link
Contributor

@max-allan max-allan commented Nov 27, 2023

The checksum for libuv was not the same as what is currently downloading. Fixed that.

$ curl  https://dist.libuv.org/dist/v1.47.0/libuv-v1.47.0-dist.tar.gz | sha256sum
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 1615k  100 1615k    0     0  2815k      0 --:--:-- --:--:-- --:--:-- 2810k
72a187104662b47f2a2b204da39d2acb05cf22a4fcb13ceaebe3b0ed0c0e2e43  -

The GPG signature for the file uses a key mentioned in the project's MAINTAINERS file.

ncurses.yaml Outdated Show resolved Hide resolved
Copy link
Member

@rawlingsj rawlingsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this fixing a bug for the ncurses build? I'm not sure that the ncurses changes are needed.

@vaikas vaikas mentioned this pull request Nov 28, 2023
11 tasks
ncurses.yaml Outdated Show resolved Hide resolved
@rawlingsj
Copy link
Member

@max-allan thanks for that, as it happens, it will have caused apk resolver issues if we moved away from using a date in the package.version.

We've since merged 405cb36.

Would you mind if we remove the ncurses change from this PR and we can get the libuv change merged?

Thanks for spotting and helping with this!

@max-allan
Copy link
Contributor Author

@rawlingsj , sorry for the delay. Real life got in the way. Change is only libuv.yaml now.

@kaniini kaniini enabled auto-merge December 4, 2023 18:12
@joshrwolf joshrwolf dismissed rawlingsj’s stale review December 4, 2023 20:51

dismissing now that changes are met

@kaniini kaniini added this pull request to the merge queue Dec 4, 2023
Merged via the queue into wolfi-dev:main with commit a895cd5 Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants