-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updat memory reservations #355
Conversation
How far into the game are you? 12GB even is still common in kater game I believe |
We are close to the last space elevator Phase. |
Thats interesting. I am not quite sure why they are there in the First Place? I will Update the pr in the evening. |
An important consideration is whether you're using asset streaming or not (the The reservations are there in the first place to deter people from attempting to run the server in non-ideal environments, and then coming back to complain that it doesn't work and that they're experiencing issues that don't appear to be caused by low memory (despite the fact that they are in fact). The default values are already low, so I don't think there is any reason to drop them further :) |
But why cant we Remove them? |
Coffee Stain studio has made recommendations about RAM typically used. In a server environment you should be settings limits or reservations on what you expect. I have two satisfactory containers, 3 ark ascended containers, an enshrouded container, Minecraft container, and more. I have restrictions set on every one of them incase a bug has them trying to run away with memory so if one gets buggy it doesn't take them all down. Containers by practice are meant to be limiting so they don't use a whole host's resources. If you intend to only use your server for just one satisfactory instance maybe setting up containers to do so isn't the right path. |
Okay |
So, remove the limits on your docker-compose.yml and continue to throw caution to the wind? The docker-compose is just a template. You can change it, without changing it for everyone. |
I know I just wanted to improve the compose file |
@DenuxPlays to quote my own reply above:
As @gotanks0407 rightfully pointed out, if you'd rather they weren't there, just remove them from your own file. Docker Compose files are intended as templates, allowing you to customize as you see fit. From my perspective, a maintainer's priority should be minimising the potential for unnecessary mistakes, while ensuring that a project remains simple to use with adequate documentation. Removing this guideline would not improve the Compose file in my opinion :) Many Docker images do not specify resource reservations as they generally cannot realistically predict the resource requirements due to the flexibility of the application (e.g. an NGINX web server could use next-to-nothing, or it could use the entirety of a dedicated server). In this case, we do have a decent enough idea, where even the shell scripts that run directly call out your low RAM allocation if it's below 8GB (just reduced from the very old requirement of 12GB). I've just updated the documentation to clarify the RAM requirements further. |
Ahh okay now I understand. Btw sorry I Must have missed your First reply to explaining why Memory Limits etc are used. Thank You for your second explenation :) |
I recently noticed that my satisactory server only uses 2GB so reserving 4GB is too much imo.
The RAM usage does shoot up when a few players join (in my case up to 5.4GB with 3 players and a late game world).
But I do think that this is some kind of bug as after a restart the server only uses 2 GB even with a players.
TLDR: