Onboarding: Clean up unused MC settings data

[joemcgill]

This is a follow-up to #2494. Once the MC settings related to the pre-launch policy check is removed from the API, those settings can be removed from other places that they are referenced.

The SettingsData type definition in /src/data/actions.js

google-listings-and-ads/js/src/data/actions.js

Lines 87 to 91 in 007190f

	* @property {boolean} [website_live] Whether the store website is live.
	* @property {boolean} [checkout_process_secure] Whether the checkout process is complete and secure.
	* @property {boolean} [payment_methods_visible] Whether the payment methods are visible on the website.
	* @property {boolean} [refund_tos_visible] Whether the refund policy and terms of service are visible on the website.
	* @property {boolean} [contact_info_visible] Whether the phone number, email, and/or address are visible on the website.

The SetupFreeListings component.

google-listings-and-ads/js/src/components/free-listings/setup-free-listings/index.js

Lines 38 to 42 in dd73ec6

	'website_live',
	'checkout_process_secure',
	'payment_methods_visible',
	'refund_tos_visible',
	'contact_info_visible',

and

https://github.com/woocommerce/google-listings-and-ads/blob/feature/2494-remove-pre-launch-checklist-items/js/src/components/free-listings/setup-free-listings/index.js#L217-L221

The relevant settings are:

• 'website_live'
• 'checkout_process_secure'
• 'payment_methods_visible'
• 'refund_tos_visible'
• 'contact_info_visible'

Acceptance criteria

• The settings references identified above are removed from the codebase.
• Setting up free listings during onboarding (step 2) or editing free listings after onboarding still work as expected (no regressions).

[joemcgill]

@mikkamp we noticed this additional cleanup after #2494. Can you confirm that this looks right?

[mikkamp]

Yes that looks alright, in #2494 I mainly mentioned the PolicyCompliance classes which are part of the PHP side. The js parts which reference these same settings/endpoints can be removed as well, which you have listed above.

If you search for mc/policy_check you might find a few more references that could be removed, like: https://github.com/woocommerce/google-listings-and-ads/blob/2.8.4/js/src/data/resolvers.js#L173-L195

[joemcgill]

Thanks @mikkamp. I'm unsure if the resolver for the mc/policy_check endpoint can be removed, because we haven't removed that endpoint. We'll go ahead and remove the settings that we identified and if there are additional things to clean up, they could be handled in follow-up PRs.

[eclarke1]

@joemcgill discussion ongoing here as to whether this ticket can be closed. Please advise.

[joemcgill]

Yep, looks like this was handled in a follow-up during code review. See: #2584 (review). Closing as complete.