-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding: Clean up unused MC settings data #2584
Onboarding: Clean up unused MC settings data #2584
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/2458-streamline-onboarding #2584 +/- ##
=======================================================================
- Coverage 65.2% 63.8% -1.4%
=======================================================================
Files 800 325 -475
Lines 22899 5083 -17816
Branches 1230 1231 +1
=======================================================================
- Hits 14928 3241 -11687
+ Misses 7803 1674 -6129
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right to me. I tested this by editing the free listings from the dashboard after completing onboarding and everything seems to be working still, as expected.
@ankitguptaindia can you confirm?
QA/Test Report- ✅Testing Environment -
Test Results -
Functional Demo / Screencast -. Recording.817.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same cleanup in #2532 has been made and merged into the feature/2458-streamline-onboarding
branch. Ref: d78738a
I also tested the merge of this PR locally and it resulted in an empty commit.
git checkout feature/2458-streamline-onboarding
git merge origin/feature/remove-redundant-settings
git diff HEAD~1 HEAD
This PR can be closed.
Closing this as it's already handled in #2532 Check comment #2584 (review) |
Changes proposed in this Pull Request:
Closes #2572 .
Setting up free listings during onboarding (step 2) or editing free listings after onboarding still work as expected (no regressions)
Screenshots:
Detailed test instructions:
Additional details:
Changelog entry