Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/Implement React Testing Libray #38

Closed
jconroy opened this issue Oct 29, 2020 · 1 comment · Fixed by #41
Closed

Add/Implement React Testing Libray #38

jconroy opened this issue Oct 29, 2020 · 1 comment · Fixed by #41
Assignees
@ecgan

Comments

@jconroy
Copy link
Member

jconroy commented Oct 29, 2020 •
edited
Loading

We'll want to add tests for our code - that includes Javascript.

Blocks and wc-admin are aligning on using the React Testing Library (RTL) - we should too.

This is an issue for tracking setting up the React Testing Library in this repository.

Obviously at the moment we don't have anything specific to test - feel free to add a dummy component etc.

Reference material:

woocommerce/woocommerce-blocks#2528
woocommerce/woocommerce-admin#4221
woocommerce/woocommerce-admin#5123
@jconroy jconroy added the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Oct 29, 2020
@jconroy
Copy link
Member Author

jconroy commented Oct 29, 2020

@ecgan care to take a look at this one?

@jconroy jconroy mentioned this issue Oct 29, 2020
Closed
21 tasks
This was referenced Oct 30, 2020
Merged
Closed
@jconroy jconroy removed the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Nov 2, 2020
@ecgan ecgan closed this as completed in #41 Nov 2, 2020
@puntope puntope mentioned this issue Nov 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecgan ecgan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/react testing library woocommerce/google-listings-and-ads
2 participants
@jconroy @ecgan