Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Add React Testing Library #4221

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Add React Testing Library #4221

merged 1 commit into from
Apr 27, 2020

Conversation

psealock
Copy link
Collaborator

Adds React Testing Library . The Homepage seems like a good opportunity to add good test coverage from the start.

Reactions seem to be favorable: p7bbVw-3Di-p2.

@psealock psealock added [Status] Needs Review focus: home screen Issues around the new home screen feature labels Apr 27, 2020
@psealock psealock requested a review from a team April 27, 2020 03:32
Copy link
Contributor

@joshuatf joshuatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we're moving forward with the React Testing Library. Tests for the homepage are passing ✅

LGTM!

@psealock psealock force-pushed the add/react-testing-library branch from 625bd37 to a7c5964 Compare April 27, 2020 21:33
@psealock psealock merged commit a976608 into master Apr 27, 2020
@psealock psealock deleted the add/react-testing-library branch April 27, 2020 22:15
@timmyc
Copy link
Contributor

timmyc commented Apr 30, 2020

This might be a cool thing to demo in a team hangout, thanks for getting this in @psealock

@mattsherman
Copy link
Contributor

Thanks for adding this in @psealock! I've started using React Testing Library in #4287.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: home screen Issues around the new home screen feature tool: monorepo infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants