Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify path in URL to make additional pages work with WooCommerce Navigation #665

Closed
ecgan opened this issue May 25, 2021 · 2 comments · Fixed by #743
Closed

Modify path in URL to make additional pages work with WooCommerce Navigation #665

ecgan opened this issue May 25, 2021 · 2 comments · Fixed by #743
Assignees
Milestone

Comments

@ecgan
Copy link
Member

ecgan commented May 25, 2021

User story

This issue is an additional follow up to issue #285 based on the discoveries found in PR #605.

From the PR #605 description:

WC Navigation menu items are displayed based on path in the URL. If the path does not correspond to any items in the WC Navigation, then it will show the root WooCommerce level. This presents a problem for us in the report pages, because we have Programs Report at path=/google/reports/programs and Products Report at path=/google/reports/products, but we only have one "Reports" menu item in the WC Navigation, which I have tied to path=/google/reports/programs. This means that when we are displaying Programs Report, WC Navigation will display the menu item correctly, but when we navigate to Products Report, WC Navigation will show the root WooCommerce level.

And from #605 (comment) in response to @eason9487's review findings:

To fix this, we need to deal with the path, e.g. for edit free listings page, instead of using path=/google/edit-free-campaign, we use path=/google/dashboard&subpath=edit-free-campaign so that when edit free listings page is displayed, the Dashboard menu item is displayed and highlighted. We can think of it as edit free listings page is a child of dashboard page.

This issue is to find all the pages and make the necessary changes so that when GLA pages is displayed, the WC Navigation should display the GLA menu level and not the WC root level.

The pages include but may not be limited to:

  • Programs Report
  • Products Report
  • Edit Free Listings
  • Add another paid campaign
  • Edit paid campaign
  • (... other possible pages...)
@ecgan ecgan self-assigned this May 25, 2021
@ecgan ecgan added this to the 1.0 milestone May 25, 2021
@ecgan
Copy link
Member Author

ecgan commented May 25, 2021

@jconroy, since #285 has the 1.0 milestone, I have added this follow-up issue to the 1.0 milestone too. Let me know if we want to deprioritize this.

@jconroy
Copy link
Member

jconroy commented May 25, 2021

Thanks @ecgan , @joshuatf (or another isotopian) might be able to help us tackle this quickly (if there is a work around)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants