Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve landing page URL for policy compliance checks #1825

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

songchen2022
Copy link
Contributor

@songchen2022 songchen2022 commented Dec 21, 2022

Changes proposed in this Pull Request:

We should only consider the url for the products with publish status

Reference from this issue

We add this fix to help query only products with publish status.

Detailed test instructions:

  1. Create only one product and set it to a publish product.
  2. Go through the onboarding steps and confirm that the check "Confirm your store is live and accessible to all users" is passed.

Changelog entry

  • Tweak - Retrieve a published product as a landing page URL.

Copy link
Contributor

@mikkamp mikkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, I can confirm that I get a successful response when creating a private product.

The only suggestion I have is to add a changelog entry in the PR, something like this.

* Tweak - Retrieve a published product as a landing page URL.

@songchen2022
Copy link
Contributor Author

Thanks for reviewing. I added the changelog as you suggested.

@mikkamp mikkamp merged commit 938564d into woocommerce:develop Dec 22, 2022
@eason9487 eason9487 added the changelog: tweak Small change, that isn't actually very important. label Dec 28, 2022
@eason9487 eason9487 mentioned this pull request Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants