Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API PULL - Fix PHPCS and remove wrong obsolete code #2228

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Jan 30, 2024

Changes proposed in this Pull Request:

This PR fixes some PHPCS warnings created in GoogleListingAndAds.php

This was due to some old wrong code that got into the feature branch.

  1. Observe this WIP commit adding some functions in GoogleListingAndAds.php -- 25db819
  2. Observe this PR when we add the Jetpack functions in their own file -- Add the missing functions required for the WPCOM OAuth flow. #2145
  3. Observe this commit when we remove the functions from GoogleListingAndAds.php -- 6975f77

At some point the code in point 1. Was not removed. This PR removes it.

Additionally, this PR solves PHPCS errors undetected in test files.

Detailed test instructions:

  1. Follow the testing guide defined in Add the missing functions required for the WPCOM OAuth flow. #2145
  2. See there are no more PHPCS errors

Additional details:

Changelog entry

@puntope puntope self-assigned this Jan 30, 2024
@github-actions github-actions bot added changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug. labels Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99f5b9e) 58.5% compared to head (b4fa9c5) 58.9%.
Report is 12 commits behind head on feature/google-api-project.

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##             feature/google-api-project   #2228     +/-   ##
==============================================================
+ Coverage                          58.5%   58.9%   +0.3%     
+ Complexity                         4248    4236     -12     
==============================================================
  Files                               458     458             
  Lines                             16919   16876     -43     
==============================================================
+ Hits                               9906    9935     +29     
+ Misses                             7013    6941     -72     
Flag Coverage Δ
php-unit-tests 58.9% <100.0%> (+0.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Google/NotificationsService.php 85.4% <100.0%> (ø)
src/Infrastructure/GoogleListingsAndAdsPlugin.php 0.0% <ø> (ø)
src/Jobs/Notifications/ProductNotificationJob.php 96.7% <100.0%> (+96.7%) ⬆️
src/Product/ProductHelper.php 95.4% <100.0%> (ø)

@puntope puntope marked this pull request as ready for review January 30, 2024 17:15
@puntope puntope requested a review from jorgemd24 January 30, 2024 17:16
Copy link
Contributor

@jorgemd24 jorgemd24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the old Jetpack functions and fixing the PHPCS! LGTM! 👍

@puntope puntope merged commit e79488c into feature/google-api-project Jan 31, 2024
11 checks passed
@puntope puntope deleted the fix/phpcs branch January 31, 2024 18:14
@eason9487 eason9487 mentioned this pull request Mar 26, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants