-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gtag consent mode v0 support #2290
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## update/global-site-tag-for-analytics-version-2 #2290 +/- ##
==================================================================================
- Coverage 63.9% 63.8% -0.0%
- Complexity 4196 4197 +1
==================================================================================
Files 455 455
Lines 17853 17859 +6
==================================================================================
Hits 11400 11400
- Misses 6453 6459 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tomalec, thanks for your work on consent in GLA!
I've left two comments on the docs but all is working well so LGTM ✅
Changes proposed in this Pull Request:
Add the minimalistic implementation to add support for Google Consent mode
We want to add MVP ASAP before Google starts penalizing merchants without this setup. (pcTzPl-25o-p2)
This PR adds a basic default and documents how to customize/extend it.
Screenshots:
Detailed test instructions:
Additional details:
Changelog entry