Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set woocommerce_gla_wcs_url to api.woocommerce.com #2319

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

martynmjones
Copy link
Contributor

@martynmjones martynmjones commented Mar 18, 2024

Changes proposed in this Pull Request:

The connect server has now been migrated and we're redirecting traffic from api-vipgo.woocommerce.com to api.woocommerce.com.

This PR updates the default woocommerce_gla_wcs_url value to api.woocommerce.com.

Detailed test instructions:

  1. Confirm existing connections work as expected after updating to this branch
  2. Confirm that new connections can be established

Changelog entry

Update - Set default connect server URL to api.woocommerce.com

@martynmjones martynmjones self-assigned this Mar 18, 2024
@github-actions github-actions bot added the changelog: update Big changes to something that wasn't broken. label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.8%. Comparing base (292cf66) to head (806370e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2319      +/-   ##
============================================
+ Coverage       53.9%   63.8%    +9.9%     
- Complexity         0    4205    +4205     
============================================
  Files            293     455     +162     
  Lines           3719   17878   +14159     
  Branches         533       0     -533     
============================================
+ Hits            2006   11412    +9406     
- Misses          1261    6466    +5205     
+ Partials         452       0     -452     
Flag Coverage Δ
js-unit-tests ?
php-unit-tests 63.8% <100.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/PluginHelper.php 82.9% <100.0%> (ø)

... and 747 files with indirect coverage changes

@martynmjones martynmjones marked this pull request as ready for review March 18, 2024 17:41
@martynmjones martynmjones requested a review from a team March 18, 2024 17:41
Copy link
Member

@ianlin ianlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martynmjones for updating the connect server url. The new domain worked as expected, LGTM.

@martynmjones martynmjones merged commit 256c91e into develop Mar 19, 2024
13 checks passed
@martynmjones martynmjones deleted the update/connect-server-url branch March 19, 2024 06:39
@tomalec tomalec mentioned this pull request Mar 19, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: update Big changes to something that wasn't broken.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants