Add support for program types when requesting a review #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog: fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2344 +/- ##
=========================================
Coverage 64.5% 64.5%
- Complexity 4252 4253 +1
=========================================
Files 458 458
Lines 18041 18046 +5
=========================================
+ Hits 11634 11638 +4
- Misses 6407 6408 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martynmjones
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Hey @puntope, thanks for adding support for program types reviews.
Tested locally with an instance of the connect server running https://github.com/Automattic/woocommerce-connect-server/pull/2404 and was able to successfully request a review with a specified program type. So LGTM ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Currently, when requesting a review, we merged all the program types (free listings and shopping ads) into one single region. Then we call WCS for requesting the review for both programs Free Listings and Shopping Ads.
This PR adds a "types" param in the request review request with the programs required to review per each region. That way we can request a review in WCS only to the required program types. If both programs are requested, only Free Listings one is processed in WCS
Screenshots
Screen.Recording.2024-04-03.at.14.35.24.mov
Related PR
https://github.com/Automattic/woocommerce-connect-server/pull/2404
Detailed test instructions:
Since we are testing a full review Request in https://github.com/Automattic/woocommerce-connect-server/pull/2404 in this PR I advise to alter the types param to have only 'shoppingads' type.
Additional details:
Changelog entry