Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the debug dependency under @automattic/components to use version 4.3.1 #2359

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 10, 2024

Bumps the npm_and_yarn group with 1 update: @automattic/components.

Updates @automattic/components from 2.0.1 to 2.1.0

Changelog

Sourced from @​automattic/components's changelog.

2.1.0

  • Update social-logos to ^2.5.2 (#72876)
  • Remove the HappinessEngineersTray component and the dependencies on @automattic/data-stores, @automattic/search and wpcom-proxy-request
Commits
Maintainer changes

This version was pushed to npm by a8c, a new releaser for @​automattic/components since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps the npm_and_yarn group with 1 update: [@automattic/components](https://github.com/Automattic/wp-calypso/tree/HEAD/packages/components).


Updates `@automattic/components` from 2.0.1 to 2.1.0
- [Release notes](https://github.com/Automattic/wp-calypso/releases)
- [Changelog](https://github.com/Automattic/wp-calypso/blob/trunk/packages/components/CHANGELOG.md)
- [Commits](https://github.com/Automattic/wp-calypso/commits/desktop-2.1.0/packages/components)

---
updated-dependencies:
- dependency-name: "@automattic/components"
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added javascript Pull requests that update Javascript code type: technical debt - dependency extraction This issue/PR suffers from the dependency extraction and management labels Apr 10, 2024
@eason9487 eason9487 added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Apr 10, 2024
@eason9487
Copy link
Member

The JavaScript unit tests failed because the v27 jest used by @wordpress/scripts doesn't support the conditional exports in package.json. It would be better to handle this PR after upgrading @wordpress/scripts.

@eason9487
Copy link
Member

eason9487 commented Apr 12, 2024

After further attempts, it was found there's almost no appropriate way to deal with this issue at the moment.

  • Upgrade @wordpress/scripts: it requires react@^18.0.0 but this is blocked by packages depending on @woocommerce/components
  • Upgrade @wordpress/scripts and override react@<18 to 18: There are a lot of packages that need to be upgraded and corresponding tweaks, but it's obviously better to wait until @woocommerce/* has been upgraded to React 18.
  • Add a config to resolve CJS memize: It was then realized that @automattic/[email protected] is missing dependencies such as @automattic/i18n-utils, which still causes jest to fail.

@eason9487 eason9487 changed the title Bump @automattic/components from 2.0.1 to 2.1.0 in the npm_and_yarn group Override the debug dependency under @automattic/components to use version 4.3.1 Apr 12, 2024
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Considering:

  • The only result of npm ls "debug@>=4.0.0 <4.3.1" is used by @automattic/happychat-connection, which is completely irrelevant to this plugin.
  • @woocommerce/components is a DEWPed package.
  • The upgrade of @automattic/components is blocked by these reasons.

The related vulnerability could be considered as a false alert. It should be fine to use overrides in package.json instead.

@eason9487 eason9487 merged commit 8085c2b into develop Apr 12, 2024
3 checks passed
@eason9487 eason9487 deleted the dependabot/npm_and_yarn/npm_and_yarn-09d56c03cb branch April 12, 2024 09:34
@eason9487 eason9487 removed the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type: technical debt - dependency extraction This issue/PR suffers from the dependency extraction and management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant