-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline campaign setup: Consolidate the campaign setup UI in the onboarding with the one in the Ads-onboarding and add the billing setup back #2623
Conversation
…onsolidate-ad-creation-ccf-merged
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/2459-campaign-creation-flow #2623 +/- ##
=====================================================================
+ Coverage 61.8% 62.1% +0.3%
=====================================================================
Files 327 327
Lines 5108 5109 +1
Branches 1242 1244 +2
=====================================================================
+ Hits 3157 3171 +14
+ Misses 1771 1756 -15
- Partials 180 182 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…onsolidate-ad-creation-ccf-merged
@ankitguptaindia Can you kindly test the changes please? I also added items to double check in the QAB. Extra issues to test: |
QA/Test Report- ✅Testing Environment -
Test Results - Tested the use cases described here #2623 (comment) and paid ad creation flow after the recent changes. New paid ad campaign and editing ad campaign flow and other related use cases are working fine now. Functional Demo / Screencast - Recording.905.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other issues:
- After submitting to create or edit a campaign, an uncaught error occurs.
- The
CampaignFormValues
type no longer has thecountryCodes
property.
google-listings-and-ads/js/src/components/types.js
Lines 6 to 7 in d7f0d51
* @typedef {Object} CampaignFormValues * @property {Array<CountryCode>} countryCodes Selected country codes for the paid ads campaign.
@eason9487 The uncaught error has been fixed. Can you kindly check again please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work. LGTM.
Changes proposed in this Pull Request:
Closes #2535 .
Replace this with a good description of your changes & reasoning.
Detailed test instructions:
Extra issues to test:
Additional details:
Changelog entry