PHP Units tests: Symlink WC instead of moving the WC folder #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemd24
changed the title
tomalec
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Thanks @jorgemd24 for fixing the workflow setup!
I checked the code and the workflow run and ran it for WC 9.4.0-beta.1. The tests were installed correctly and correctly failed on the unit test failure. LGTM
mikkamp
reviewed
Sep 26, 2024
bin/install-wp-tests.sh
Outdated
| touch "$WC_VERSION_FILE" | ||
|
|
||
| ln -s "${WC_TMPDIR}"/plugins/woocommerce "$WC_DIR" | ||
| touch "$WC_VERSION_FILE" |
There was a problem hiding this comment.
Just a small note here about mixed spacing. This line uses a tab and 2 spaces.
There was a problem hiding this comment.
Sharp-eyed! Fixed here 2583950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes p1725522825461799-slack-C0410KV3YLW
The PHP Unit tests couldn't be installed because a dependency located in the WooCommerce repo is outside the plugin folder. The issue is because we moved the WC folder inside the plugin folder, preventing
composerfrom accessing packages in the WooCommerce repo.WC composer.json: https://github.com/woocommerce/woocommerce/blob/37bb36994b08d417e34b9043fea0bf92a3f9c236/plugins/woocommerce/composer.json#L19-L24
Package: https://github.com/woocommerce/woocommerce/tree/trunk/packages/php/blueprint
This PR resolve the issue by symlinking the WooCommerce folder instead of moving it.
The error was the following:
Source path "../../packages/php/blueprint" is not found for package woocommerce/blueprintSee: https://github.com/woocommerce/google-listings-and-ads/actions/runs/11035010424/job/30658509144#step:6:81
Screenshots:
Detailed test instructions:
Additional details:
It seems that one test is failing:
test_delete_created_product_calls_notify_directlybut doesn't seem related to this PR.Changelog entry