Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unnecessary files under js/src #2712

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

Noticed a few unused files when working on #2711.

This PR removes them along with the test case of trialing Jest tests with @testing-library/react.

💡 I will be skipping code review since this PR only includes developer-facing only change.

Detailed test instructions:

Confirm the npm run dev can build frontend code without errors

Changelog entry

@eason9487 eason9487 self-assigned this Dec 5, 2024
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.4%. Comparing base (7cd33a8) to head (2d36ead).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #2712     +/-   ##
=========================================
- Coverage     63.4%   63.4%   -0.0%     
=========================================
  Files          340     339      -1     
  Lines         5210    5207      -3     
  Branches      1275    1275             
=========================================
- Hits          3305    3302      -3     
  Misses        1730    1730             
  Partials       175     175             
Flag Coverage Δ
js-unit-tests 63.4% <ø> (-<0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@eason9487 eason9487 merged commit 3490c3d into develop Dec 5, 2024
9 checks passed
@eason9487 eason9487 deleted the dev/clean-up-unnecessary-files branch December 5, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant