Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of the saved max shipping time not showing after revisiting the free listings editing page #2725

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Dec 13, 2024

Changes proposed in this Pull Request:

This PR fixes the issue of the saved max shipping time not showing after revisiting the free listings editing page.

Kapture.2024-12-13.at.16.59.50.mp4

Screenshots:

Kapture.2024-12-13.at.17.01.44.mp4

Detailed test instructions:

  1. Go to edit free listings
  2. Edit a max shipping time save it
  3. Back to Dashboard by clicking the < button at the top-left side of the page
    image
  4. Go to edit free listings again
  5. Check if the saved max time is shown

Changelog entry

Fix - The saved max shipping time is not showing after revisiting the free listings editing page.

@eason9487 eason9487 requested a review from a team December 13, 2024 09:08
@eason9487 eason9487 self-assigned this Dec 13, 2024
@github-actions github-actions bot added type: bug The issue is a confirmed bug. changelog: fix Took care of something that wasn't working. labels Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.4%. Comparing base (ff37b09) to head (63ca753).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2725      +/-   ##
============================================
- Coverage       66.2%   63.4%    -2.8%     
============================================
  Files            479     338     -141     
  Lines          19608    5203   -14405     
  Branches           0    1274    +1274     
============================================
- Hits           12983    3301    -9682     
+ Misses          6625    1728    -4897     
- Partials           0     174     +174     
Flag Coverage Δ
js-unit-tests 63.4% <100.0%> (?)
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
js/src/data/reducer.js 82.5% <100.0%> (ø)

... and 816 files with indirect coverage changes

Copy link
Member

@ianlin ianlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it. Confirmed the max shipping was shown after saving and revisiting the edit free listing page.

@eason9487 eason9487 merged commit ac11774 into develop Dec 16, 2024
9 checks passed
@eason9487 eason9487 deleted the fix/empty-max-shipping-time branch December 16, 2024 07:55
@eason9487 eason9487 mentioned this pull request Dec 18, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants