Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the minimum supported WordPress version to 6.1 to align with the minimum supported WooCommerce #2743

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

In #2723, the minimum supported WooCommerce was updated to 7.9, and the minimum WordPress it supports is 6.1, so this PR aligns the minimum supported WordPress version to the same.

See: https://github.com/woocommerce/woocommerce/blob/7.9.0/plugins/woocommerce/woocommerce.php#L11

Detailed test instructions:

Search the codebase to see if there are any WordPress versions noted that have not been updated together.

Changelog entry

Update - Drop support for WordPress < 6.1.

@eason9487 eason9487 requested a review from a team December 20, 2024 12:11
@eason9487 eason9487 self-assigned this Dec 20, 2024
@github-actions github-actions bot added the changelog: update Big changes to something that wasn't broken. label Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.0%. Comparing base (9c3514c) to head (e0744fb).
Report is 31 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2743      +/-   ##
============================================
+ Coverage       63.5%   67.0%    +3.5%     
- Complexity         0    4692    +4692     
============================================
  Files            337     479     +142     
  Lines           5193   19612   +14419     
  Branches        1273       0    -1273     
============================================
+ Hits            3299   13136    +9837     
- Misses          1721    6476    +4755     
+ Partials         173       0     -173     
Flag Coverage Δ
js-unit-tests ?
php-unit-tests 67.0% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
google-listings-and-ads.php 75.0% <ø> (ø)

... and 815 files with indirect coverage changes

@tomalec tomalec self-requested a review December 25, 2024 17:47
Copy link
Member

@tomalec tomalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @eason9487 ! :)
I searched the code for older WP references, and run dewped in case we're using any older versions. All look good to me

 dewped pdep  --wpVersion=6.1.7 -c 7.9.1 -d .externalized.json 
 ›   Warning: @woocommerce/block-templates version not found in WooCommerce 7.9.1 at 
 ›   https://raw.githubusercontent.com/woocommerce/woocommerce/7.9.1/packages/js/block-templates/package.json.
 ›   Warning: @woocommerce/settings version not found in WooCommerce 7.9.1 at 
 ›   https://raw.githubusercontent.com/woocommerce/woocommerce/7.9.1/packages/js/settings/package.json.
 Name                               WordPress 6.1.7 WooCommerce 7.9.1 Local    
 ────────────────────────────────── ─────────────── ───────────────── ──────── 
 @woocommerce/block-templates                       unknown                    
 @woocommerce/components                            12.0.0            ^12.3.0  
 @woocommerce/currency                              4.2.0             ^4.3.0   
 @woocommerce/customer-effort-score                 2.2.0             ^3.0.0   
 @woocommerce/data                                  4.1.0             ^5.0.0   
 @woocommerce/date                                  4.2.0             ^4.3.0   
 @woocommerce/navigation                            8.1.0             ^8.2.0   
 @woocommerce/number                                2.4.0             ^2.5.0   
 @woocommerce/product-editor                        1.0.0-beta.0               
 @woocommerce/settings                              unknown                    
 @woocommerce/tracks                                1.3.0             ^1.4.0   
 @wordpress/api-fetch               6.14.1                            ^6.39.13 
 @wordpress/components              21.0.7                            ^25.8.14 
 @wordpress/compose                 5.15.2                            ^6.19.13 
 @wordpress/data                    7.1.3                             ^9.12.13 
 @wordpress/data-controls           2.17.3                            ^3.11.13 
 @wordpress/date                    4.17.1                            ^4.42.13 
 @wordpress/dom                     3.17.2                            ^3.42.13 
 @wordpress/element                 4.15.1                            ^5.19.13 
 @wordpress/hooks                   3.17.1                            ^3.42.13 
 @wordpress/html-entities           3.17.1                            ^3.42.13 
 @wordpress/i18n                    4.17.1                            ^4.42.13 
 @wordpress/primitives              3.15.1                            ^3.40.13 
 @wordpress/url                     3.18.1                            ^3.43.13 
 jquery                             3.6.1                                      
 lodash                             4.17.21                           ^4.17.21 
 react                              17.0.2                                     
 react-dom                          17.0.2    

@eason9487 eason9487 merged commit ce6894f into develop Dec 30, 2024
14 checks passed
@eason9487 eason9487 deleted the update/requires-at-least-wp-6-1 branch December 30, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: update Big changes to something that wasn't broken.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants