Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests in WooCommerce 9.6 #2754

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fix tests in WooCommerce 9.6 #2754

merged 2 commits into from
Jan 9, 2025

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Jan 8, 2025

Changes proposed in this Pull Request:

Tests are failing when using 9.6.0-beta.2

  • One test regarding the default weight measure unit
  • Another regarding the Features. That are not loaded anymore in our test environment.

That is because the code in https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/src/Admin/Features/Features.php#L56

This PR adapts the test to fix those 2.

Screenshots:

Screenshot 2025-01-08 at 21 34 53

Detailed test instructions:

  1. See the test using 9.6.0-beta.2 passing against this branch
    2.See the test using latest passing against this branch

Additional details:

Changelog entry

Dev - Fix tests in WooCommerce 9.6

@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Jan 8, 2025
@puntope puntope marked this pull request as ready for review January 8, 2025 20:43
@puntope puntope self-assigned this Jan 8, 2025
@puntope puntope requested a review from a team January 8, 2025 20:43
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM.

@puntope puntope merged commit 90b564d into develop Jan 9, 2025
18 of 19 checks passed
@puntope puntope deleted the dev/fix-tests-wc9.6 branch January 9, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants