Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility issue that lacks required class of new WC Navigation in supported WC versions #718

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Fix compatibility issue that lacks required class of new WC Navigation in supported WC versions #718

merged 2 commits into from
Jun 4, 2021

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

  • Add a new trait to check the availability of new WooCommerce Navigation and if it's enabled
  • Replace Features::is_enabled( 'navigation' ) by the new trait to fix compatibility issue

Bug

Replicate steps:

  1. Install WC with a version that doesn't have the Automattic\WooCommerce\Admin\Features class. I tested with WC 4.9.2.
  2. Deactivate the WooCommerce Admin plugin
  3. The whole WP admin would be broken
    2021-06-02 16 51 05

Detailed test instructions:

Follow the same steps of bug replication steps, and the WP admin should be able to use.

Changelog Note:

Fix compatibility issue that lacks required class of new WC Navigation in supported WC versions

@eason9487 eason9487 requested a review from a team June 2, 2021 09:12
@eason9487 eason9487 self-assigned this Jun 2, 2021
@jconroy
Copy link
Member

jconroy commented Jun 4, 2021

Great catch @eason9487

@jconroy jconroy added this to the 1.0 milestone Jun 4, 2021
jconroy
jconroy approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@jconroy jconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing well, thanks @eason9487

@eason9487 eason9487 merged commit c2d2160 into trunk Jun 4, 2021
@eason9487 eason9487 deleted the fix/wc-nav-availability branch June 4, 2021 03:30
@tomalec tomalec mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jconroy jconroy jconroy approved these changes

Assignees

@eason9487 eason9487

Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@eason9487 @jconroy