This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Add GitHub pages deploy step to Travis config. #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffstieler
force-pushed
the
add/gh-pages-build-step
branch
2 times, most recently
from
6ca134b to
d051344
Compare
jeffstieler
force-pushed
the
add/gh-pages-build-step
branch
from
d051344 to
a8b0e9c
Compare
jeffstieler
added
[Status] Needs Review
type: documentation
psealock
approved these changes
Sep 24, 2019
|
Nifty! I wasn't aware of the docs for woocommerce admin until just now and I think this is awesome to have up. Gutenberg is just wrapping up implementing docs using Storybook. One thing I like about that approach is the live component views (which also verify they are working). I wonder if that's something we should consider implementing at some point as well? |
|
Our live components live under WooCommerce > DevDocs (when running It's probably best long term to just do it the Gutenberg Way ™️. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to introduce a deploy step on Travis that pushes the built
docs/folder to thegh-pagesbranch, since it now relies on a symlink to thepackages/components/srcdirectory.The deploy should only occur on commits to
masterand on the PHP 7.2 / JS build.Once this is merged and the first deploy occurs, we can switch the repo settings to build GH pages from the
gh-pagesbranch.Since travis-ci/dpl#989, this should copy the files symlinked. If that doesn't actually occur, this approach will need to be revisited - but we need to commit this to see if it works.