-
Notifications
You must be signed in to change notification settings - Fork 144
Try: Register plugins under separate navigation menu #5513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @joshuatf for the great work! This is testing well here and code LGTM
hey @joshuatf I think the styling for the extensions header is fine here, and as you mentioned we can consider updating that in the near future. Wanted to confirm, when there are no extensions installed the extensions section won't appear in the nav? |
That's correct, @elizaan36 - the |
'path' => '/analytics/overview', | ||
'nav_args' => array( | ||
'order' => 10, | ||
'parent' => 'analytics', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshuatf, this is a nice addition with nav_args
. Small change, but I'm thinking id
could also go under nav_args
since its used only for matching a slot with the client's fill.
Update the nav to the "Plugins" approach.
Fixes #5530
Note: this PR does not update the styling to the group title "Extensions." The group title styling is different than that shown in #5530. I think this is something we may want to tackle upstream.
Screenshots
Detailed test instructions:
npm run example -- --ext=add-navigation-items
and activate.