This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 221
Fix registered payment methods not recognized by Checkout block on initial insertion into content #2579
Merged
nerrad
merged 1 commit into
master
from
fix/payments-not-loading-on-initial-block-insertion
May 27, 2020
Merged
Fix registered payment methods not recognized by Checkout block on initial insertion into content #2579
nerrad
merged 1 commit into
master
from
fix/payments-not-loading-on-initial-block-insertion
May 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerrad
added
status: needs review
type: bug
The issue/PR concerns a confirmed bug.
labels
May 27, 2020
Size Change: 0 B Total Size: 2.06 MB ℹ️ View Unchanged
|
Aljullu
approved these changes
May 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming it fixes the issue.
senadir
approved these changes
May 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nerrad
added a commit
that referenced
this pull request
May 27, 2020
nerrad
added
the
release: cherry-pick
Cherry picked into the relevant release branch.
label
May 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release: cherry-pick
Cherry picked into the relevant release branch.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2576
The issue here was that the registered payment methods were not being initialized before the checkout block assets were registered. So this meant when the checkout block assets were registered for the block editor, the script handles for registered payment method handles were not added to the block asset dependencies and thus not loaded with that asset.
By changing the priority on the payment method registration initialization, the issue is fixed.
To Test
To reproduce, you can follow the steps outlined by Albert in #2576.