Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix registered payment methods not recognized by Checkout block on initial insertion into content #2579

Merged
merged 1 commit into from
May 27, 2020

Conversation

nerrad
Copy link
Contributor

@nerrad nerrad commented May 27, 2020

Fixes: #2576

The issue here was that the registered payment methods were not being initialized before the checkout block assets were registered. So this meant when the checkout block assets were registered for the block editor, the script handles for registered payment method handles were not added to the block asset dependencies and thus not loaded with that asset.

By changing the priority on the payment method registration initialization, the issue is fixed.

To Test

To reproduce, you can follow the steps outlined by Albert in #2576.

  • Verify that the following the reproduction steps demonstrate the issue is fixed.
  • Verify that you can complete a Stripe CC or cheque payment and there are no console errors when interacting with the Checkout block on the frontend or in the editor.

@nerrad nerrad requested a review from a team as a code owner May 27, 2020 16:25
@nerrad nerrad requested review from mikejolley and removed request for a team May 27, 2020 16:25
@nerrad nerrad self-assigned this May 27, 2020
@nerrad nerrad added status: needs review type: bug The issue/PR concerns a confirmed bug. labels May 27, 2020
@nerrad nerrad added this to the 2.6.0 milestone May 27, 2020
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 2.06 MB

ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 7.25 kB 0 B
build/active-filters.js 7.89 kB 0 B
build/all-products-frontend.js 71.9 kB 0 B
build/all-products.js 19.2 kB 0 B
build/all-reviews-legacy.js 10.3 kB 0 B
build/all-reviews.js 10.6 kB 0 B
build/attribute-filter-frontend.js 16.7 kB 0 B
build/attribute-filter.js 11.5 kB 0 B
build/block-error-boundary-legacy.js 774 B 0 B
build/block-error-boundary.js 774 B 0 B
build/blocks-legacy.js 2.92 kB 0 B
build/blocks.js 2.92 kB 0 B
build/cart-frontend.js 113 kB 0 B
build/cart.js 32.3 kB 0 B
build/checkout-frontend.js 129 kB 0 B
build/checkout.js 37.8 kB 0 B
build/custom-select-control-style-legacy.js 782 B 0 B
build/custom-select-control-style.js 782 B 0 B
build/editor-legacy-rtl.css 12.5 kB 0 B
build/editor-legacy.css 12.6 kB 0 B
build/editor-rtl.css 13.5 kB 0 B
build/editor.css 13.5 kB 0 B
build/featured-category-legacy.js 146 kB 0 B
build/featured-category.js 146 kB 0 B
build/featured-product-legacy.js 9.49 kB 0 B
build/featured-product.js 9.81 kB 0 B
build/handpicked-products-legacy.js 6.88 kB 0 B
build/handpicked-products.js 7.15 kB 0 B
build/panel-style-legacy.js 773 B 0 B
build/panel-style.js 773 B 0 B
build/price-filter-frontend.js 14.1 kB 0 B
build/price-filter.js 9.97 kB 0 B
build/product-best-sellers-legacy.js 6.96 kB 0 B
build/product-best-sellers.js 7.22 kB 0 B
build/product-categories-legacy.js 3.22 kB 0 B
build/product-categories.js 3.21 kB 0 B
build/product-category-legacy.js 7.87 kB 0 B
build/product-category.js 8.14 kB 0 B
build/product-list-style-legacy.js 775 B 0 B
build/product-new-legacy.js 7.11 kB 0 B
build/product-new.js 7.39 kB 0 B
build/product-on-sale-legacy.js 7.49 kB 0 B
build/product-on-sale.js 7.79 kB 0 B
build/product-search-legacy.js 3.12 kB 0 B
build/product-search.js 3.36 kB 0 B
build/product-tag-legacy.js 6.08 kB 0 B
build/product-tag.js 6.33 kB 0 B
build/product-top-rated-legacy.js 7.09 kB 0 B
build/product-top-rated.js 7.36 kB 0 B
build/products-by-attribute-legacy.js 7.85 kB 0 B
build/products-by-attribute.js 8.11 kB 0 B
build/reviews-by-category-legacy.js 12.3 kB 0 B
build/reviews-by-category.js 12.7 kB 0 B
build/reviews-by-product-legacy.js 13.8 kB 0 B
build/reviews-by-product.js 14.2 kB 0 B
build/reviews-frontend-legacy.js 8.03 kB 0 B
build/reviews-frontend.js 8.95 kB 0 B
build/single-product-frontend.js 58.9 kB 0 B
build/single-product.js 4.17 kB 0 B
build/snackbar-notice-style-legacy.js 778 B 0 B
build/snackbar-notice-style.js 778 B 0 B
build/spinner-style-legacy.js 775 B 0 B
build/spinner-style.js 771 B 0 B
build/style-legacy-rtl.css 5.62 kB 0 B
build/style-legacy.css 5.63 kB 0 B
build/style-rtl.css 16.6 kB 0 B
build/style.css 16.6 kB 0 B
build/vendors-legacy.js 376 kB 0 B
build/vendors-style-legacy-rtl.css 1.65 kB 0 B
build/vendors-style-legacy.css 1.65 kB 0 B
build/vendors-style-legacy.js 105 B 0 B
build/vendors-style-rtl.css 1.65 kB 0 B
build/vendors-style.css 1.65 kB 0 B
build/vendors-style.js 105 B 0 B
build/vendors.js 474 kB 0 B
build/wc-blocks-data.js 7.08 kB 0 B
build/wc-blocks-middleware.js 931 B 0 B
build/wc-blocks-registry.js 1.79 kB 0 B
build/wc-payment-method-cheque.js 794 B 0 B
build/wc-payment-method-paypal.js 830 B 0 B
build/wc-payment-method-stripe.js 11.9 kB 0 B
build/wc-settings.js 2.14 kB 0 B

compressed-size-action

Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming it fixes the issue.

Copy link
Member

@senadir senadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nerrad nerrad merged commit c8ae305 into master May 27, 2020
@nerrad nerrad deleted the fix/payments-not-loading-on-initial-block-insertion branch May 27, 2020 16:34
@nerrad nerrad added the release: cherry-pick Cherry picked into the relevant release branch. label May 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release: cherry-pick Cherry picked into the relevant release branch. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
4 participants