This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
refactor StyleAttributesUtils #5277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
gigitux
approved these changes
Nov 30, 2021
gigitux
added a commit
that referenced
this pull request
Nov 30, 2021
* Add global style for product categories list block #4965 Add global style for product categories list block * add support for link color * add feature flag * fix code style and PHP warning * update doc comment * remove empty space * refactor StyleAttributesUtils (#5277) Co-authored-by: Tung Du <[email protected]>
tjcafferkey
added
skip-changelog
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* Add global style for product categories list block woocommerce#4965 Add global style for product categories list block * add support for link color * add feature flag * fix code style and PHP warning * update doc comment * remove empty space * refactor StyleAttributesUtils (woocommerce#5277) Co-authored-by: Tung Du <[email protected]>
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
* Add global style for product categories list block woocommerce#4965 Add global style for product categories list block * add support for link color * add feature flag * fix code style and PHP warning * update doc comment * remove empty space * refactor StyleAttributesUtils (woocommerce#5277) Co-authored-by: Tung Du <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor the
StyleAttributesUtilsintroduced in #5133. The issue with the original implementation to me is, we still need a lot of code to get the space-separated classes/styles - which is the main use-case of the utils. This PR refactor it so we can get desired properties in an immutable way without complex calculation in the markup.