Release: 8.7.1

assets/js/blocks-registry/payment-methods/payment-method-config-helper.ts

@@ -50,6 +50,12 @@ export const canMakePaymentWithExtensions =
 
 			Object.entries( extensionsCallbacks ).forEach(
 				( [ namespace, callbacks ] ) => {
+					if (
+						! ( paymentMethodName in callbacks ) ||
+						typeof callbacks[ paymentMethodName ] !== 'function'
+					) {
+						return;
+					}
 					namespacedCallbacks[ namespace ] =
 						callbacks[ paymentMethodName ];
 				}

assets/js/blocks-registry/payment-methods/test/payment-method-config-helper.ts

@@ -88,6 +88,9 @@ describe( 'payment-method-config-helper', () => {
 				woopay: trueCallback,
 				// testpay: one callback errors, one returns true
 				testpay: throwsCallback,
+				// Used to check that only valid callbacks run in each namespace. It is not present in
+				// 'other-woocommerce-marketplace-extension'.
+				blocks_pay: trueCallback,
 			}
 		);
 		registerPaymentMethodExtensionCallbacks(
@@ -202,5 +205,14 @@ describe( 'payment-method-config-helper', () => {
 			expect( throwsCallback ).toHaveBeenCalledTimes( 1 );
 			expect( trueCallback ).toHaveBeenCalledTimes( 1 );
 		} );
+
+		it( 'Does not error when a callback for a payment method is in one namespace but not another', () => {
+			helpers.canMakePaymentWithExtensions(
+				() => true,
+				canMakePaymentExtensionsCallbacks,
+				'blocks_pay'
+			)( canMakePaymentArgument );
+			expect( console ).not.toHaveErrored();
+		} );
 	} );
 } );

docs/internal-developers/testing/releases/871.md

@@ -0,0 +1,15 @@
+# Testing notes and ZIP for release 8.7.1
+
+Zip file for testing: [woocommerce-gutenberg-products-block.zip](https://github.com/woocommerce/woocommerce-blocks/files/9766268/woocommerce-gutenberg-products-block.zip)
+
+## Feature plugin and package inclusion in WooCommerce
+
+### Fixed an issue where JavaScript errors would occur when more than one extension tried to filter specific payment methods in the Cart and Checkout blocks ([7377](https://github.com/woocommerce/woocommerce-blocks/pull/7377))
+
+#### User Facing Testing
+
+1. Install and activate [some-extension-name.zip](https://github.com/woocommerce/woocommerce-blocks/files/9764404/some-extension-name.zip) and [WooCommerce Conditional Shipping and Payments](https://woocommerce.com/products/conditional-shipping-and-payments/).
+2. Activate the Cash on Delivery payment method.
+3. Go to the Cart block and view the JS console. Ensure you don't see any errors such as `Error when executing callback for cheque in some-extension-name TypeError: namespacedCallbacks[namespace] is not a function`.
+4. Go to the Checkout block and check that no similar errors appear.
+5. Change your city to `Denver` and ensure the Cash on Delivery method is not available.

docs/internal-developers/testing/releases/README.md

@@ -92,6 +92,7 @@ Every release includes specific testing instructions for new features and bug fi
     -   [8.5.1](./851.md)
 -   [8.6.0](./860.md)
 -   [8.7.0](./870.md)
+    -   [8.7.1](./871.md)
 
 <!-- FEEDBACK -->
 

readme.txt

@@ -80,6 +80,10 @@ Release and roadmap notes available on the [WooCommerce Developers Blog](https:/
 
 == Changelog ==
 
+= 8.7.1 - 2022-10-12 =
+
+- Fixed an issue where JavaScript errors would occur when more than one extension tried to filter specific payment methods in the Cart and Checkout blocks. ([7377](https://github.com/woocommerce/woocommerce-blocks/pull/7377))
+
 = 8.7.0 - 2022-10-10 =
 
 #### Enhancements