Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging in Ajax requests for ECE #3533

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Add logging in Ajax requests for ECE #3533

merged 4 commits into from
Oct 24, 2024

Conversation

Mayisha
Copy link
Contributor

@Mayisha Mayisha commented Oct 23, 2024 •
edited
Loading

Changes proposed in this Pull Request:

I have added some logging in the critical Ajax requests with possible failure scenarios (similar to WooPayments).

Testing instructions

  • Code review should be enough.
  • Or you can intentionally throw some error from the functions and check if the error is logged as expected.

@Mayisha Mayisha requested review from a team and annemirasol and removed request for a team October 23, 2024 05:03
annemirasol
annemirasol approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@annemirasol annemirasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

✅ Did some smoke testing with ECE purchases and everything looks good.
✅ Forced an exception for ajax_create_order and verified logs look good.

@Mayisha Mayisha merged commit 4bb5743 into develop Oct 24, 2024
34 of 35 checks passed
@Mayisha Mayisha deleted the task/ece-logging branch October 24, 2024 03:24
@Mayisha Mayisha mentioned this pull request Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annemirasol annemirasol annemirasol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mayisha @annemirasol