Adding Amazon Pay to the classic checkout #3793
Open
+148
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrosa
force-pushed
the
add/amazon-pay-to-classic-checkout
branch
from
56943b2 to
ed5e933
Compare
wjrosa
commented
Jan 30, 2025
| @@ -41,8 +41,9 @@ public function __construct() { | |||
| * @return string | |||
| */ | |||
| public function get_title( $payment_details = false ) { | |||
| if ( $payment_details && isset( $payment_details->card->wallet->type ) ) { | |||
| return $this->get_card_wallet_type_title( $payment_details->card->wallet->type ); | |||
| $wallet_type = WC_Stripe_Payment_Methods::AMAZON_PAY === ( $payment_details->type ?? null ) ? WC_Stripe_Payment_Methods::AMAZON_PAY : ( $payment_details->card->wallet->type ?? null ); | |||
There was a problem hiding this comment.
Maybe I should replace this with another IF. A bit confusing to read.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3733
Changes proposed in this Pull Request:
Testing instructions
changelog.txtandreadme.txt(or does not apply)Post merge