Stripe appearance improvements #3795
Conversation
- Send background color to Stripe - Fix text color - Introduce style variables
We already have a global text color in variables. Use of label styles for Text doesn't quite work for dark themes. So we remove the customization here so that it uses default Stripe styles (gray text) which looks good on both light/dark themes.
This time using paragraph rules instead of label rules
malithsen
requested review from
a team and
annemirasol
and removed request for
a team
| '.Text': isColorLight( backgroundColor ) | ||
| ? darkParagraphRules | ||
| : paragraphRules, | ||
| '.Text--redirect': isColorLight( backgroundColor ) | ||
| ? darkParagraphRules |
There was a problem hiding this comment.
darkParagraphRules are obtained from the hidden input field. When using a dark palette, we use input text color for non-input text. This is a bit hacky but needed because, in shortcode checkout, there's always a light overlay. So, if we use paragraph rules, we will have light text on a light background.
There was a problem hiding this comment.
I see this for block checkout, 2025 theme. Is this expected?
There was a problem hiding this comment.
@annemirasol That doesn't look right. This is what I get
Can you double-check the transients in the db to make sure it's not using the cached styles?
There was a problem hiding this comment.
Oof, you're right! I forgot to clear the transients in between switching palettes!
Fixes #3788, #3789
Changes proposed in this Pull Request:
This PR introduces a series of minor fixes to improve the visibility of Stripe payment fields.
With a light color palette
With a dark color palette
Testing instructions
select * from wp_options where option_name like '%_appearance%')changelog.txtandreadme.txt(or does not apply)Post merge