Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the handling of express method titles #3844

Open
wants to merge 6 commits into
base: tweak/hiding-actions-for-pending-amazon-pay-orders
Choose a base branch
from

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Feb 5, 2025

Changes proposed in this Pull Request:

This PR improves how we handle express payment method titles by introducing new constants and methods to replace duplicate code.

Testing instructions

Code review should be enough. Check if tests are still passing.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@wjrosa wjrosa self-assigned this Feb 5, 2025
@wjrosa wjrosa marked this pull request as ready for review February 6, 2025 12:51
@wjrosa wjrosa requested review from a team and diegocurbelo and removed request for a team February 6, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant