Adding admin notices for detached subscriptions #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrosa
commented
Feb 11, 2025
| @@ -58,6 +65,11 @@ public function admin_notices() { | |||
| // All other payment methods. | |||
| $this->payment_methods_check_environment(); | |||
|
|
|||
| // Subscription related checks. | |||
| if ( class_exists( 'WC_Subscriptions' ) && class_exists( 'WC_Subscription' ) && version_compare( WC_Subscriptions::$version, '2.2.0', '>=' ) ) { | |||
There was a problem hiding this comment.
I have moved a helper method with this check here so we can use it in non-gateway classes.
diegocurbelo
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Thanks for fixing this so quickly @wjrosa 👏🏼
The code looks good, and it tests well 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: p1739145321956079-slack-C7U3Y3VMY
Changes proposed in this Pull Request:
This PR adds new admin notices to alert merchants when subscriptions payment methods are detached, preventing renewals from happening. This should help them be more proactive in identifying and fixing this kind of issue.
Testing instructions
add/admin-notices-for-detached-subscriptions)(you can also just set
$payment_method->customertonullin thesubscriptions_check_environmentmethod)changelog.txtandreadme.txt(or does not apply)Post merge