-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide separate commit-title
and commit-message
in pipeline metadata
#2359
Comments
What if we just leave new lines in the commit messages. This way it would be quite easy for the different places to decide if they just want to show the first line or more. |
Sure, I thought it might be more handy for users this way, and it's done just once on the server-side. As a plugin author I can deal with newlines as well and for the Web UI we can of course also handle this easily. Feel free to close. |
I think the issue is however that the commit message is a one-liner atm? |
Not in DB, but in UI it's shown without newlines (but the data is available) |
In that case we could just show the first line normally and on hover the full message with new-lines |
This issue was intended to be unrelated to the Web UI PR. The Web UI "issue" can be of course improved easily. |
I think we can close this (see #2359 (comment))? |
We should expose
commit-title
andcommit-message
as dedicated metadata on the server-side because sometimes the title is more useful/readable instead of the full message e.g. in notification plugins or web UI.posted by @xoxys in #2356 (comment)
The text was updated successfully, but these errors were encountered: