Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jsonnet support #1396

Closed
wants to merge 1 commit into from
Closed

Conversation

qwerty287
Copy link
Contributor

@qwerty287 qwerty287 commented Nov 5, 2022

Jsonnet is a templating language for JSON.

Example for a pipeline config (running with local backend):

{
    pipeline: [
        {
            name: "bash-step",
            image: "bash",
            commands: ["echo Hello " + self.image + "!"],
        },
        self.pipeline[0] { name: "zsh-step", image: "zsh" },
    ]
}

which is evaluated into:

{
   "pipeline": [
      {
         "commands": [
            "echo Hello bash!"
         ],
         "image": "bash",
         "name": "bash-step"
      },
      {
         "commands": [
            "echo Hello zsh!"
         ],
         "image": "zsh",
         "name": "zsh-step"
      }
   ]
}

@qwerty287 qwerty287 added feature add new functionality pipeline-config related to pipeline config files (.yaml) labels Nov 5, 2022
@qwerty287 qwerty287 added this to the 1.0.0 milestone Nov 5, 2022
@6543
Copy link
Member

6543 commented Nov 5, 2022

I'm against it and for a global "compile" step that is plugin based ..

@anbraten ?

@codecov-commenter

This comment was marked as off-topic.

Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per comment - we need to chat about this clearly

@lafriks
Copy link
Contributor

lafriks commented Nov 5, 2022

I also agree that this should be made plugable at least by clear interface than they could be either builtin or external plugins

@qwerty287
Copy link
Contributor Author

Closing as per discussion

@qwerty287 qwerty287 closed this Nov 5, 2022
@6543
Copy link
Member

6543 commented Nov 5, 2022

still thanks for looking into it :)

@6543 6543 mentioned this pull request Nov 6, 2022
@6543
Copy link
Member

6543 commented Nov 6, 2022

-> #1400

@qwerty287 qwerty287 deleted the jsonnet branch November 7, 2022 16:11
0x1def pushed a commit to flakybitnet/woodpecker that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature add new functionality pipeline-config related to pipeline config files (.yaml)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants