Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish alpine container #398

Merged
merged 12 commits into from
Oct 4, 2021
Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 4, 2021

  • Enable build & publish of alpine docker container
  • Delete outdated BUILD file
  • Move Dockerfiles into subdir "docker"
  • Update & format Dockerfiles
  • Introduce "next" tag

close #288

@6543 6543 added the build CI pipeline related label Oct 4, 2021
@6543 6543 added this to the 0.15.0 milestone Oct 4, 2021
@6543 6543 requested a review from anbraten October 4, 2021 13:58
@anbraten
Copy link
Member

anbraten commented Oct 4, 2021

@6543 What about #257?

@6543
Copy link
Member Author

6543 commented Oct 4, 2021

@anbraten I'll rebase that one

@6543 6543 enabled auto-merge (squash) October 4, 2021 14:07
@6543
Copy link
Member Author

6543 commented Oct 4, 2021

PS: added you as co-author in the squash-merge since took some parts from #257 ...

.woodpecker/main.yml Outdated Show resolved Hide resolved
.woodpecker/main.yml Outdated Show resolved Hide resolved
.woodpecker/main.yml Outdated Show resolved Hide resolved
.woodpecker/main.yml Outdated Show resolved Hide resolved
.woodpecker/main.yml Outdated Show resolved Hide resolved
.woodpecker/main.yml Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Oct 4, 2021

we can do the latest is latest stable once we did release v0.15.0 else we would have to downgrade current latest witch would break installations unnecessary who did just migrate breaking changes etc ...

@anbraten
Copy link
Member

anbraten commented Oct 4, 2021

Okay I think we could start with next and keep latest until 0.15.0 got released on master pushes as well.
I updated my suggestions accordingly.

6543 and others added 2 commits October 4, 2021 16:22
prepare for "latest" and "next" split

Co-authored-by: Anbraten <[email protected]>
.woodpecker/main.yml Outdated Show resolved Hide resolved
.woodpecker/main.yml Outdated Show resolved Hide resolved
.woodpecker/main.yml Outdated Show resolved Hide resolved
Copy link
Member Author

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@6543 6543 requested a review from anbraten October 4, 2021 14:29
@6543 6543 disabled auto-merge October 4, 2021 14:30
@6543 6543 enabled auto-merge (squash) October 4, 2021 14:31
@anbraten
Copy link
Member

anbraten commented Oct 4, 2021

Okay almost. Could you add next tag to /docs/downloads with a small description on latest vs next?

@anbraten
Copy link
Member

anbraten commented Oct 4, 2021

Ahh and we need to fix .dockerignore. Atm it pushes all files to the build context. I fixed that in #257 by only adding the dockerfile and binary to a folder used as context. see here

@6543
Copy link
Member Author

6543 commented Oct 4, 2021

Ahh and we need to fix .dockerignore. Atm it pushes all files to the build context. I fixed that in #257 by only adding the dockerfile and binary to a folder used as context. see here

I think we dont need that, it's not within the final image ...

@6543 6543 merged commit e3354e4 into woodpecker-ci:master Oct 4, 2021
@6543 6543 deleted the alpine-container branch October 4, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI pipeline related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tidy up Dockerfiles and remove dependency on drone/ca-certs
2 participants