Rework pipeline messages #4626
Draft
Rework pipeline messages #4626
+1,674
−953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwerty287
added
the
breaking
|
@qwerty287 Why is that breaking? Because of the env var change? |
|
Yes, env var change and it also changes the json for the pipeline model |
|
Deploying preview to https://woodpecker-ci-woodpecker-pr-4626.surge.sh |
|
@woodpecker-ci/maintainers somebody has an idea how to fix the DB tests? https://ci.woodpecker-ci.org/repos/3780/pipeline/24869/38 Besides that, this PR can get first reviews. It still needs testing and the UI is probably not the best. Also, there are some todos, especially in the bitbucket code. Maybe @langecode you can check this out? |
|
Can you add a bit more context about what has changed and how it fixes the linked issue? IMO it helps to provide a more detailed PR description in addition to the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #3421
closes #2971
todo