Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDOWS: psutil can fail to get process info #123

Merged
merged 1 commit into from
May 31, 2022

Conversation

mattip
Copy link
Contributor

@mattip mattip commented May 12, 2022

Preallocate a default process dict with the valid PID, and return it when get_process_info errors. Also catch psutil.AccessDenied on windows where sometimes the user cannot query all processes.

@mattip
Copy link
Contributor Author

mattip commented May 12, 2022

Fixes #123

@mattip
Copy link
Contributor Author

mattip commented May 31, 2022

Could a maintainer kick off the CI for this PR? This issue is causing problems on ray's use of gpustat...

Copy link
Collaborator

@Stonesjtu Stonesjtu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattip
Copy link
Contributor Author

mattip commented May 31, 2022

I fixed the test

gpustat/core.py Outdated Show resolved Hide resolved
@mattip mattip force-pushed the psutils-windows branch from 2fd59ed to 0509573 Compare May 31, 2022 11:26
@mattip
Copy link
Contributor Author

mattip commented May 31, 2022

Fixes #121

@mattip
Copy link
Contributor Author

mattip commented May 31, 2022

This needs a maintainer to kick off CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants