Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not list the same GPU process more than once #84

Merged
merged 2 commits into from
May 19, 2020
Merged

Conversation

wookayin
Copy link
Owner

@wookayin wookayin commented May 4, 2020

A single process might appear in both of graphics and compute running
processes list (#18). In such cases, the same process (same PID)
would appear appearing twice. We fix this bug: list a process only once.

A single process might appear in both of graphics and compute running
processes list (#18). In such cases, the same process (same PID)
would appear appearing twice. We fix this bug: list a process only once.
@wookayin wookayin requested a review from Stonesjtu May 4, 2020 02:31
@wookayin wookayin added this to the 1.0 milestone May 4, 2020
@wookayin wookayin added the bug label May 4, 2020
Copy link
Collaborator

@Stonesjtu Stonesjtu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

gpustat/core.py Show resolved Hide resolved
@Stonesjtu
Copy link
Collaborator

I've added comments to illustrate, merging it.

@Stonesjtu Stonesjtu merged commit aba85f8 into master May 19, 2020
@wookayin
Copy link
Owner Author

wookayin commented May 19, 2020

Please do more careful job on commit messages when squashing commits.

@Stonesjtu
Copy link
Collaborator

Could you give any detailed suggestions on squashing?

@wookayin wookayin deleted the fix-duplicate branch August 5, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants