-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MDXContent
to allow missing props
#83
Conversation
* Make sure logical and is applied to Object.assign call within MDXContent function
Sweet, thanks for working on this! I think it would be better to solve it in the argument list: Also, could you update the example in the readme following “The actual output of running node example.js is:”? There are also two errors in the tests on CI. the babel one looks a bit flakey (I’ll check if that’s still the case), but the error message might need to be changed? |
ps. run |
Rebasing your PR against main should solve the weird babel error |
The other error was related due to a change in Node 16.9. Updates the tests to fix that as well. |
@wooorm Sounds like a plan. I'll adjust the fix to provide a default value for the props parameter and work on the test errors. |
@wooorm I've updated my branch with your changes to main and am able to run |
MDXContent
to allow missing props
Thanks, released! |
Adjusts MDXContent function output to allow undefined props as a parameter without throwing a TypeError.
Closes #82