Fix expectation of props being passed to components
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Components defined in MDX content should be able to receive arbitrary props. The main `MDXContent` component, though, receives `props.components`. Previously their was a mix up where the code did not differentiate between the two. The handling of whether a variable was defined or not (which is needed for the rewrite that allows components being passed in and provided through context) was also too naïve. This commit fixes that. Closes GH-53.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components defined in MDX content should be able to receive arbitrary
props.
The main
MDXContentcomponent, though, receivesprops.components.Previously their was a mix up where the code did not differentiate
between the two.
The handling of whether a variable was defined or not (which is needed
for the rewrite that allows components being passed in and provided
through context) was also too naïve.
This commit fixes that.
Closes GH-53.