Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve validation for search route and refactor test code #548

Merged
merged 3 commits into from
May 26, 2024

Conversation

JadenKim-dev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When invalid request body is sent to the search route, the error message returned is ambiguous.
It makes it difficult to determine from the message which part of the request is invalid.

Test cases for validation are not grouped in detail, making them difficult to understand.

Issue Number: N/A

What is the new behavior?

More detailed error message is returned, allowing clients to identify where the validation failed for search route.
Each test case is grouped so that one can understand what tests are being performed just by looking at the test results.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Additionally, I removed duplicated logging and validation logic.
For now test coverage for line improved to 100%.

@jiho-kr jiho-kr merged commit 19db835 into woowabros:main May 26, 2024
3 checks passed
@JadenKim-dev JadenKim-dev deleted the feature/interceptor branch May 26, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants