refactor: improve validation for search route and refactor test code #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When invalid request body is sent to the search route, the error message returned is ambiguous.
It makes it difficult to determine from the message which part of the request is invalid.
Test cases for validation are not grouped in detail, making them difficult to understand.
Issue Number: N/A
What is the new behavior?
More detailed error message is returned, allowing clients to identify where the validation failed for search route.
Each test case is grouped so that one can understand what tests are being performed just by looking at the test results.
Does this PR introduce a breaking change?
Other information
Additionally, I removed duplicated logging and validation logic.
For now test coverage for line improved to 100%.