Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken ci (not found docker-compose) #630

Merged
merged 17 commits into from
Aug 17, 2024

Conversation

jiho-kr
Copy link
Contributor

@jiho-kr jiho-kr commented Aug 17, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

CI fails because it can't find Docker Compose.

Run yarn test:ci
yarn run v1.22.22
$ yarn docker-compose-up:test && yarn test && yarn docker-compose-down:test
$ docker-compose -f docker-compose.test.yml --env-file .env.test up -d
/bin/sh: 1: docker-compose: not found
error Command failed with exit code 12[7](https://github.com/woowabros/nestjs-library-crud/actions/runs/10254655043/job/28592771801?pr=622#step:10:8).
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 127.

What is the new behavior?

Add a Docker Compose installation on CI.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jiho-kr jiho-kr force-pushed the feature/docker-compose branch from 451e4b0 to 6f5750a Compare August 17, 2024 10:59
@jiho-kr jiho-kr force-pushed the feature/docker-compose branch from 6f5750a to 6f3ed2a Compare August 17, 2024 11:01
@jiho-kr jiho-kr self-assigned this Aug 17, 2024
@jiho-kr jiho-kr merged commit 452ea56 into woowabros:main Aug 17, 2024
3 checks passed
@jiho-kr jiho-kr deleted the feature/docker-compose branch August 17, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant