아이템 수정 & 데이로그 수정 & 아이템 oridinal 수정 재업로드 #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Jacoco Test Coverage
|
LJW25
approved these changes
Oct 13, 2023
|
|
||
| @Override | ||
| public void updateOrdinals(final List<Long> orderedItemIds) { | ||
| final String sql = "UPDATE item SET ordinal = :newOrdinal WHERE id = :itemId"; |
There was a problem hiding this comment.
얘는 줄바꿈 안하나요? 짧아서 안해도 되는건가?!
jjongwa
approved these changes
Oct 13, 2023
waterricecake
approved these changes
Oct 13, 2023
mcodnjs
reviewed
Oct 13, 2023
Comment on lines
+108
to
+115
| private Place makeUpdatedPlace(final ItemUpdateRequest itemUpdateRequest, final Item item) { | ||
| final Place originalPlace = item.getPlace(); | ||
| if (isPlaceNotUpdated(itemUpdateRequest, item)) { | ||
| return originalPlace; | ||
| } | ||
| final Place updatedPlace = createPlaceByPlaceRequest(itemUpdateRequest.getPlace()); | ||
| deleteNotUsedPlace(originalPlace); | ||
| return saveNewlyUpdatedPlace(updatedPlace); |
mcodnjs
approved these changes
Oct 13, 2023
jjongwa
pushed a commit
that referenced
this pull request
Oct 19, 2023
* refactor: 아이템, 데이로그 수정 쿼리 개선 * refactor: 아이템 수정 로직 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
이전 PR
아이템 수정 로직 좀 더 가독성있게 수정함. (근데 아직도 가독성 좋은 지 잘 모르겠음) 커밋
아이템의 Place, Expense, Image의 수정 로직을 아래의 플로우로 통일 (
originalObject: 변경 요청전의 오브젝트)originalObject사용🙋🏻 More