-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Toggle 컴포넌트 재구축 및 서비스 코드 반영, 디자인시스템 v1.3.10 배포 #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
로컬 cypress 테스트가 실패했습니다. 테스트 결과 자세히 보기 |
6f3e395
to
6a6272d
Compare
로컬 cypress 테스트가 실패했습니다. 테스트 결과 자세히 보기 |
LJW25
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
훌륭합니다 리더 슬링키
hgo641
pushed a commit
that referenced
this pull request
Apr 23, 2024
* refactor: Toggle 컴포넌트 재구축 및 npm v1.3.9 배포 * refactor: toggle 변경 시 발생시킬 이벤트 코드 추가 * fix: cyprses CI 버전문제 개선을 위한 package.json 수정 * chore: Toggle style Radius 추가 * build: 디자인시스템 npm v1.3.10 배포 * chore: 불필요한 콘솔 제거
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
기존 사용의 경우 아래와 같았음.
개선 이후
이름은 기존 쓰고있던것들때문에 임시로 NewToggle로 해뒀습니다
NewToggle안에 additinalFunc는 내부적으로 변화하는 state에 의해 외부에서 컨트롤해야할 뭔가가 필요할때 쓰면 됩니다.
🙋🏻 More
#792