Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3, 4단계 - 체스] 몰리(김지민) 미션 제출합니다. #791
[3, 4단계 - 체스] 몰리(김지민) 미션 제출합니다. #791
Changes from 102 commits
24a97a3
401b894
2fb03b5
fae3909
c8b8d42
ae20320
ed77e6c
a11ca19
51ed08a
bdb1ef0
33700c3
268ac49
a5185cd
dc13a62
4183c3d
96a6038
ce8a6a3
be855f4
329b27a
f6db0b8
9bcfd67
dd21d25
5cd033a
8b7073b
16ce484
be7de57
d9477a4
aad13c2
df9bd37
a1df2a4
c4c9309
bb5bc05
71541df
16daf5b
9cd97e5
a22bf90
9763153
be5957b
5147bed
64d8039
9e89a49
ebd9b84
860d072
6bc0880
28869f3
4f759c7
c1b5f4a
d77e89a
603a772
9dc16f9
afac83e
f225430
36b1541
b6f4a58
4fd6574
b364412
6c61b9a
1f91692
5a0dbc6
041202b
4e426bb
e2a39ba
9fc8bee
4672b09
38c9b93
4470230
b2a038f
155a92e
f7c678c
2b00dc3
d7412f5
39184ca
f389cbd
2218494
b885bf1
8a7699f
235792c
3c0cc21
86ba136
a6c6b9a
611a76d
3f858ee
cf27f9b
e45545f
a2129d5
51b1699
de49715
16a8e8a
b0c8f1a
3e5aec1
ee89cd4
498bfa5
b409982
a3f41aa
dcb595e
f9ac2f8
7345e75
2404075
3070131
89f6380
51d06e1
0c46af2
fd45dee
aec228f
19d56a1
6dec859
ca7ebd7
30e78e4
fd3f758
d2979f0
a415567
a2e7ba9
ae7bb18
513120b
3276d42
0522e16
3a44feb
eea10af
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
service 라는 명칭을 사용한 이유가 있나요? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스프링을 사용할 때, 컨트롤러와 레포지토리 사이에서 비즈니스 로직을 처리하는 Service 계층을 사용했었는데요..!
제가 생각하기에 Service 계층의 역할은 크게 2가지라고 생각합니다!
이번 미션에서 비즈니스 로직은 도메인에서 거의 처리가 되었기 때문에, 1번 역할을 수행하지는 않았는데요.
하지만 이번에 적용한 Service 객체가 2번 역할을 수행하는 용도와 닮아있다고 생각해서 Service라는 네이밍을 사용했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
비즈니스 로직은 각각의 비즈니스 객체(domain 계층)가 수행할 수 있는 걸로 보여요.
그래야 비즈니스 변경 요구사항이 전달되었을 때 controller, service 패키지를 열어볼 필요 없이
domain 패키지 탐색을 시작으로 빠르게 수정할 대상을 찾아낼 수 있기 때문이에요.
(controller 가 view 와 domain 의 소통에만 집중해야하는 것과 같은 이유)
결국 service 계층은 2번처럼 비즈니스 로직과 영속 계층사이 소통만 담당하는 것이 이상적이겠네요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵넵 그동안 service 계층에 대한 오해가 조금 있었던 것 같네요 🤣
비즈니스 로직은 각각의 비즈니스 객체가 수행한다! 명심하겠습니다 ㅎㅎ
감사합니다 현구막!