Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[부나] 3, 4단계 오목 제출합니다. #32
[부나] 3, 4단계 오목 제출합니다. #32
Changes from 9 commits
8d59987
fae3223
ea6854b
2f4f911
dad2995
9f32c95
f8c5492
84e3150
169c6c2
f4153d7
99a94dd
7ea3064
2990bb6
f314d9d
78b7c98
1713db9
b66ca08
5ca1a10
89fb85c
5f561a1
add4939
d4e3c81
3cf09c5
c0355ae
4009199
c1d4f10
8b8a053
744e6cd
6f5657c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
같은 layer 끼리 서로 의존성을 가지지 않아야 합니다.
공통되는 로직이 있다면 해당 로직만 별도 객체로 분리해주세요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
템플릿 메서드를 사용하여 공통되는 로직을 상위 클래스로 옮기고, 변경이 필요한 로직에 대해서는 별도의 서브 클래스에서 구현하도록 변경하였습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗.. 지금 리뷰를 다시 읽어 봤는데 공통되는 기능을 하나의 클래스로 분리해서 컴포지션하기를 의도하신 걸까요?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네, Composition을 의도했지만 상속을 통한 재사용도 좋습니다!