Adding support for different bullets by UL indentation level #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For parity with Gutenberg Web
|
Could this be done in a way that the bullet characters are configurable by the user of the library? |
There was a problem hiding this comment.
While the idea behind this PR is great, my understanding is that right now this change doesn't really change bullets at all - only the code in preparation for something that we're expecting will come up.
I understand and agree with the direction but my suggestion for this PR would be to either:
- Make it possible to customize the bullets as @SergioEstevao is proposing, or
- Merge this once we can swap to actually having a new bullet.
That said, @SergioEstevao 's suggestion sounds much better IMHO for a generic library.
|
I agree with you both! |
|
@etoledom are you still working on this? |
|
I haven't retaken this task yet. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for different bullets by UL indentation level for parity with Gutenberg Web:
The indented bullet will still be the same than the previous one (black bullet) until Android adds support for this too.
To test:
TextList.swift.return "\t\u{2022}"and change the unicode from2022to25E6(white bullet).