Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg - Fix Gallery block uploads when the editor is closed #13570

Merged
merged 3 commits into from
Dec 9, 2020
Merged

Gutenberg - Fix Gallery block uploads when the editor is closed #13570

merged 3 commits into from
Dec 9, 2020

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Dec 9, 2020 •
edited by guarani
Loading

Fixes an issue found while sanity testing the 1.43.0 Gutenberg mobile release.

Fixes WordPress/gutenberg#27618

Due to this Gutenberg change that updated the values for the linkTo attribute, the Gallery processor stopped working correctly. This PR updates the values to the new ones:

  • media → file
  • attachment → post

To test:

  • Gallery block - Close post with an ongoing image upload - steps

Test the different Gallery link to options: None, Media File, and Attachment Page

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 9, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 9, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@geriux geriux added this to the 16.4 milestone Dec 9, 2020
@geriux geriux marked this pull request as ready for review December 9, 2020 15:26
@antonis antonis self-requested a review December 9, 2020 15:36
@chipsnyder chipsnyder mentioned this pull request Dec 9, 2020
Merged
3 tasks
antonis
antonis approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@antonis antonis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @geriux 👍
I confirm that this works as expected with all three Gallery link options (Tested on a Pixel2 XL/Android 11) 🎉
The code changes LGTM!

@guarani
Copy link
Contributor

guarani commented Dec 9, 2020

I added an issue WordPress/gutenberg#27618 for this PR to fix and update the PR description to reflect this.

@jd-alexander jd-alexander merged commit 7f77b20 into develop Dec 9, 2020
@jd-alexander jd-alexander deleted the gutenberg/fix-gallery-block-processor branch December 9, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.4
Development

Successfully merging this pull request may close these issues.

Fix Gallery block uploads when the editor is closed
4 participants
@geriux @guarani @antonis @jd-alexander