Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding dashboard cards: remove prompts from site settings #20453

Merged
merged 2 commits into from
May 31, 2023
Merged

Hiding dashboard cards: remove prompts from site settings #20453

merged 2 commits into from
May 31, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Mar 30, 2023

Related issue: #20296

Changes

  • Remove prompts from site settings
  • Remove a notice when disabling prompts

Cards visibility is now controlled using a new Personalize Home Tab screen added in #20369 that replaced the item in Site Settings

To test

  • Enable "Personalize Home Tab" screen and open Dashboard
  • Open the Prompts card context menu and select "Turn off prompts"
  • Verify that the card got removed but not notice (snackbar) was shown
  • Open site settings
  • Verify that the "Prompts" row is not there

Regression Notes

  1. Potential unintended areas of impact. n/a (changes only affect what's in the description)
  2. What I did to test those areas of impact (or what existing automated tests I relied on). Manual testing
  3. What automated tests I added (or what prevented me from doing so). n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@kean kean changed the title Feature/personalize home tab update settings Hiding dashboard cards: remove prompts from site settings Mar 30, 2023
@kean kean requested a review from guarani May 30, 2023 22:27
@momo-ozawa momo-ozawa self-requested a review May 31, 2023 15:30
@momo-ozawa momo-ozawa added this to the 22.6 milestone May 31, 2023
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

@momo-ozawa
Copy link
Contributor

@kean I kicked off a CI build - if it's green all good to merge 😄

@kean kean merged commit 85b4819 into wordpress-mobile:trunk May 31, 2023
@kean kean deleted the feature/personalize-home-tab-update-settings branch May 31, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants